Is there memory leak?

[reika]

Hi,
I read the source code and I have a question.
The function AddArrayString() allocated memory.
But I can not find souce code to free Data.Excludes.
Is there memory leak if "-e" parameter used?

Here Data.SpaceHogs has been freed. but not Data.Excludes
/* Cleanup. */
  if (Data.SpaceHogs != NULL) {
    for (i = 0; Data.SpaceHogs != NULL; i++) free(Data.SpaceHogs);
    free(Data.SpaceHogs);
    }

BTW: My English is poor.

Thank you.

[jeroen]

The Excludes array is a parameter, it is not allocated inside the library and therefore not freed. It must be freed outside the library by the caller. The same applies to the SpaceHogs. The code you have found inside the library will free the internal copy of the spacehogs array, not the original input parameter.

In other words, the Excludes and the Spacehogs arrays should be freed in the JkDefragWindows.cpp, JkDefragCmd.cpp, and JkDefragScreenSaver2.cpp sources. It's not there, but not very important because just after returning from the library these programs will stop.

[reika]

I see.

Jeffrey Richter《Programming Applications for Microsoft Windows》chapter 3

"So, your application can leak kernel objects while it runs, but when your process terminates, the system guarantees that everything is cleaned up properly. By the way, this is true for all objects, resources, and memory blocks: when a process terminates, the system ensures that your process leaves nothing behind."

JkDefragWindows.cpp not call free() function.
Hm~~, Windows will cleanup all memory when JKD finished.
thus, "not very important".

 
Thank you.